build(deps-dev): bump typescript from 5.9.3 to 6.0.3#60
Merged
Conversation
Supersedes the failing Dependabot PR #45, which broke for two reasons that a plain version bump can't resolve: * @nextcloud/eslint-config@8 still pins its TypeScript peer to ^5.0.2, so `npm install` fails with ERESOLVE. TypeScript 6 works fine with ESLint 8 and the bundled @typescript-eslint here, so add a minimal `overrides` entry pinning typescript across the tree. Drop it once the Nextcloud preset (v9) officially lists TS 6 in its peer range. * TypeScript 6 deprecates the `baseUrl` compiler option (error TS5101), which fails `vue-tsc --noEmit`. Remove `baseUrl` and rewrite the path alias to "@/*": ["./src/*"]; `paths` resolves relative to the config dir without `baseUrl` (supported since TS 4.1). webpack and vitest resolve `@/` via their own alias config, so they are unaffected. All CI checks pass: Biome, ESLint, vue-tsc, Vitest (54 tests), webpack build.
Contributor
Preview this PR in the Nextcloud Playground
A fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades TypeScript from 5.9.3 to 6.0.3. This supersedes the failing Dependabot PR #45, which could not land as a plain version bump for two reasons:
@nextcloud/eslint-config@8still pins its TypeScript peer to^5.0.2, sonpm installaborts withERESOLVE. TypeScript 6 works fine with ESLint 8 and the bundled@typescript-eslintin this project, so a minimaloverridesentry pinstypescriptacross the tree. It can be dropped once the Nextcloud preset (v9) officially lists TS 6 in its peer range.baseUrldeprecation. TypeScript 6 deprecates thebaseUrlcompiler option (error TS5101), which failsvue-tsc --noEmit.baseUrlis removed and the path alias rewritten to"@/*": ["./src/*"]—pathsresolves relative to the config dir withoutbaseUrl(supported since TS 4.1). webpack (@nextcloud/webpack-vue-config) and vitest resolve@/via their own alias config, so they are unaffected.Changes
package.json:typescript^5.4.5→^6.0.3; addoverridespinningtypescript.tsconfig.json: remove deprecatedbaseUrl; rewritepathsalias to./src/*.package-lock.json: regenerated (typescript deduped to 6.0.3 across all consumers).Verification
All five CI frontend checks pass locally (Node 22 target):
npm run lint:biomenpm run lint(ESLint)npm run typecheck(vue-tsc)npm test(Vitest — 5 files, 54 tests)npm run build(webpack production)Closes #45.